Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267634AbUIIWEd (ORCPT ); Thu, 9 Sep 2004 18:04:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267633AbUIIWDf (ORCPT ); Thu, 9 Sep 2004 18:03:35 -0400 Received: from holomorphy.com ([207.189.100.168]:51379 "EHLO holomorphy.com") by vger.kernel.org with ESMTP id S267999AbUIIWAs (ORCPT ); Thu, 9 Sep 2004 18:00:48 -0400 Date: Thu, 9 Sep 2004 15:00:40 -0700 From: William Lee Irwin III To: Paul Mackerras Cc: Anton Blanchard , Zwane Mwaikambo , Linux Kernel , Andrew Morton , Linus Torvalds , Matt Mackall , "Nakajima, Jun" Subject: Re: [PATCH][5/8] Arch agnostic completely out of line locks / ppc64 Message-ID: <20040909220040.GM3106@holomorphy.com> Mail-Followup-To: William Lee Irwin III , Paul Mackerras , Anton Blanchard , Zwane Mwaikambo , Linux Kernel , Andrew Morton , Linus Torvalds , Matt Mackall , "Nakajima, Jun" References: <16703.60725.153052.169532@cargo.ozlabs.ibm.com> <20040909154259.GE11358@krispykreme> <20040909171954.GW3106@holomorphy.com> <16704.52551.846184.630652@cargo.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16704.52551.846184.630652@cargo.ozlabs.ibm.com> Organization: The Domain of Holomorphy User-Agent: Mutt/1.5.6+20040722i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 863 Lines: 20 William Lee Irwin III writes: >> Checking in_lock_functions() (not sure what the name in Zwane's code >> was) for non-leaf functions in get_wchan() in addition to >> in_sched_functions() should do. e.g. On Fri, Sep 10, 2004 at 07:38:15AM +1000, Paul Mackerras wrote: > Well, no, not if we are two levels deep at this point (i.e. something > calls _spin_lock which calls __preempt_spin_lock). I really don't > want to have to start doing a stack trace in profile_pc(). The semantics of profile_pc() have never included backtracing through scheduling primitives, so I'd say just report __preempt_spin_lock(). -- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/