Date: Thu, 9 Sep 2004 15:36:06 -0700
From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@osdl.org>
Cc: eric.valette@free.fr, linux-kernel@vger.kernel.org, petkan@nucleusys.com
Subject: Re: 2.6.9-rc1-mm4 badness in rtl8150.c ethernet driver : fixed
Message-ID: <20040909223605.GA17655@kroah.com>
References: <413DB68C.7030508@free.fr> <4140256C.5090803@free.fr> <20040909152454.14f7ebc9.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040909152454.14f7ebc9.akpm@osdl.org>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1244
Lines: 34

On Thu, Sep 09, 2004 at 03:24:54PM -0700, Andrew Morton wrote:
> Eric Valette <eric.valette@free.fr> wrote:
> >
> > Here is a small patch that makes the card functionnal again. I've 
> > forwarded the patch to driver author also.
> > 
> > --- linux/drivers/usb/net/rtl8150.c-2.6.9-rc1-mm4.orig	2004-09-09 11:15:11.000000000 +0200
> > +++ linux/drivers/usb/net/rtl8150.c	2004-09-09 11:15:46.000000000 +0200
> > @@ -341,7 +341,7 @@
> >  
> >  static int rtl8150_reset(rtl8150_t * dev)
> >  {
> > -	u8 data = 0x11;
> > +	u8 data = 0x10;
> 
> hm, OK.  Presumably the change (which comes in via the bk-usb tree) was
> made for a reason.  So I suspect both versions are wrong ;)
> 
> But it might be risky for Greg to merge this patch up at present.

As all your patch does is revert the patch in my tree (it was a one line
change), mainline should work just fine for you, right?

I'll defer to Petkan as to what to do about this, as he sent me that
patch for a good reason I imagine :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/