Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266345AbUIJAWU (ORCPT ); Thu, 9 Sep 2004 20:22:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266582AbUIJAWU (ORCPT ); Thu, 9 Sep 2004 20:22:20 -0400 Received: from fw.osdl.org ([65.172.181.6]:55695 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S266891AbUIJAVo (ORCPT ); Thu, 9 Sep 2004 20:21:44 -0400 Date: Thu, 9 Sep 2004 17:21:36 -0700 (PDT) From: Linus Torvalds To: William Lee Irwin III cc: Paul Mackerras , Anton Blanchard , Zwane Mwaikambo , Linux Kernel , Andrew Morton , Matt Mackall , "Nakajima, Jun" Subject: Re: [PATCH][5/8] Arch agnostic completely out of line locks / ppc64 In-Reply-To: <20040910000903.GS3106@holomorphy.com> Message-ID: References: <16703.60725.153052.169532@cargo.ozlabs.ibm.com> <20040909154259.GE11358@krispykreme> <20040909171954.GW3106@holomorphy.com> <16704.52551.846184.630652@cargo.ozlabs.ibm.com> <20040909220040.GM3106@holomorphy.com> <16704.59668.899674.868174@cargo.ozlabs.ibm.com> <20040910000903.GS3106@holomorphy.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 23 On Thu, 9 Sep 2004, William Lee Irwin III wrote: > > Unfortunately the alternative appears to be stack unwinding in > profile_pc(), which was why I hoped we could punt. Any other ideas? Why do we care about profile_pc() here? It should do the right thing as-is. What you care about is wchan, and stack unwiding _over_ the spinlocks. Since a spinlock can never be part of the wchan callchain, I vote we just change "in_sched_functions()" to claim that anything in the spinlock section is also a scheduler function as far as it's concerned. That makes wchan happy, and profile_pc() really never should care. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/