Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266730AbUIJBoB (ORCPT ); Thu, 9 Sep 2004 21:44:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266912AbUIJBoB (ORCPT ); Thu, 9 Sep 2004 21:44:01 -0400 Received: from ozlabs.org ([203.10.76.45]:60363 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S266730AbUIJBny (ORCPT ); Thu, 9 Sep 2004 21:43:54 -0400 Date: Fri, 10 Sep 2004 11:42:28 +1000 From: Anton Blanchard To: Linus Torvalds Cc: William Lee Irwin III , Paul Mackerras , Zwane Mwaikambo , Linux Kernel , Andrew Morton , Matt Mackall , "Nakajima, Jun" Subject: Re: [PATCH][5/8] Arch agnostic completely out of line locks / ppc64 Message-ID: <20040910014228.GH11358@krispykreme> References: <20040909154259.GE11358@krispykreme> <20040909171954.GW3106@holomorphy.com> <16704.52551.846184.630652@cargo.ozlabs.ibm.com> <20040909220040.GM3106@holomorphy.com> <16704.59668.899674.868174@cargo.ozlabs.ibm.com> <20040910000903.GS3106@holomorphy.com> <20040910003505.GG11358@krispykreme> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6+20040818i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 21 > But that's because "__preempt_spin_lock" on ppc is in the wrong section, > no? > > Just change it from "__sched" to "__lockfunc", and move it to > kernel/spinlock.c while you're at it, and everything works right. Do the > same for __preempt_write_lock() too. > > Oh, and you need to do the "is_sched_function()" change too that I > outlined in the previous email. Yep Im agreeing with you :) But we also need to fix profile_pc() since it wont handle the 2 deep _spin_lock -> __preempt_spin_lock. Should be no problems, ill work on this. Anton - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/