Subject: Re: The Serial Layer
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: arjanv@redhat.com,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <20040910143211.GA7342@thunk.org>
References: <1094582980.9750.12.camel@localhost.localdomain>
	 <1094587598.2801.24.camel@laptop.fenrus.com>
	 <1094584456.9745.14.camel@localhost.localdomain>
	 <20040909125705.GA5658@thunk.org>
	 <1094747324.14623.49.camel@localhost.localdomain>
	 <20040910143211.GA7342@thunk.org>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1094829666.17464.22.camel@localhost.localdomain>
Mime-Version: 1.0
Date: Fri, 10 Sep 2004 16:21:08 +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 964
Lines: 20

On Gwe, 2004-09-10 at 15:32, Theodore Ts'o wrote:
> We needed to close the line discpline in order to prevent a line
> discipline (such as ppp) from trying to write to the tty.  Given there
> was an invariant that a tty always had a line discpline always, we
> reassigned it back to N_TTY.  The right answer is probably to be to
> add checks to the line discpline code before they attempt to send data
> to the tty.

Ok that makes sense. So we need the same kind of ordering rules about
device->close() as we now enforce with ldisc->close(). That suggests we
simply need to call ldisc->close before device->close. I think we can
now do that safely as the device won't deliver data to a closed ldisc.

Will look into it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/