Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266223AbUIMHEQ (ORCPT ); Mon, 13 Sep 2004 03:04:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266236AbUIMHEQ (ORCPT ); Mon, 13 Sep 2004 03:04:16 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:42245 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S266221AbUIMHEH (ORCPT ); Mon, 13 Sep 2004 03:04:07 -0400 Date: Mon, 13 Sep 2004 09:03:35 +0200 From: Adrian Bunk To: Marcelo Tosatti , ipslinux@adaptec.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: 2.4.28-pre3: broken ips update Message-ID: <20040913070334.GD1937@fs.tum.de> References: <20040911220117.GA4669@logos.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040911220117.GA4669@logos.cnet> User-Agent: Mutt/1.5.6+20040818i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1932 Lines: 59 On Sat, Sep 11, 2004 at 07:01:17PM -0300, Marcelo Tosatti wrote: >... > Summary of changes from v2.4.28-pre2 to v2.4.28-pre3 > ============================================ >... > Jack Hammer: > o ServeRAID driver (ips) Version 7.10.18 >... <-- snip --> ... gcc-3.4 -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.28-pre3-full/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon -fno-unit-at-a-time -nostdinc -iwithprefix include -DKBUILD_BASENAME=ips -c -o ips.o ips.c In file included from ips.c:190: ips.h:101: error: redefinition of typedef 'irqreturn_t' /home/bunk/linux/kernel-2.4/linux-2.4.28-pre3-full/include/linux/interrupt.h:16: error: previous declaration of 'irqreturn_t' was here make[3]: *** [ips.o] Error 1 make[3]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.28-pre3-full/drivers/scsi' <-- snip --> This update was obviously submitted without even testing the compilation of the driver (not to mention testing whether it actually works). Even worse: We had _exactly the same problem_ with the 7.00.15 driver in 2.4.27-pre3, but 7.10.18 now simply reverts my (trivial) fix for this compile error. Marcelo, can you please refuse patches from people who don't bother to do even the simplest compile testing when blindly submitting the latest version of a driver? TIA Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/