Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266704AbUIMNZ4 (ORCPT ); Mon, 13 Sep 2004 09:25:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266721AbUIMNZ4 (ORCPT ); Mon, 13 Sep 2004 09:25:56 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:57580 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S266704AbUIMNZx (ORCPT ); Mon, 13 Sep 2004 09:25:53 -0400 Date: Mon, 13 Sep 2004 15:25:30 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@scrub.home To: Hugh Dickins cc: Alex Zarochentsev , Paul Jackson , William Lee Irwin III , Hans Reiser , linux-kernel@vger.kernel.org, Andrew Morton , Martin Schwidefsky Subject: Re: 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 703 Lines: 20 Hi, On Mon, 13 Sep 2004, Hugh Dickins wrote: > But Bill already said he doesn't want it, [...] > > - if (atomic_sub_and_test(bio->bi_vcnt, &fq->nr_submitted)) > + if (atomic_sub_return(bio->bi_vcnt, &fq->nr_submitted) == 0) And that is more portable how? atomic_sub_and_test() allows some archs to generate better code and the rest can still fall back to atomic_sub_return. (Maybe it's time for / ?) bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/