Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266756AbUIMNvy (ORCPT ); Mon, 13 Sep 2004 09:51:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266768AbUIMNvy (ORCPT ); Mon, 13 Sep 2004 09:51:54 -0400 Received: from bay-bridge.veritas.com ([143.127.3.10]:53321 "EHLO MTVMIME03.enterprise.veritas.com") by vger.kernel.org with ESMTP id S266756AbUIMNvw (ORCPT ); Mon, 13 Sep 2004 09:51:52 -0400 Date: Mon, 13 Sep 2004 14:51:05 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@localhost.localdomain To: Roman Zippel cc: Alex Zarochentsev , Paul Jackson , William Lee Irwin III , Hans Reiser , , Andrew Morton , Martin Schwidefsky Subject: Re: 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 671 Lines: 20 On Mon, 13 Sep 2004, Roman Zippel wrote: > On Mon, 13 Sep 2004, Hugh Dickins wrote: > > > But Bill already said he doesn't want it, [...] > > > > - if (atomic_sub_and_test(bio->bi_vcnt, &fq->nr_submitted)) > > + if (atomic_sub_return(bio->bi_vcnt, &fq->nr_submitted) == 0) > > And that is more portable how? It's more portable in that all but s390 already provide it (and I expect Martin will be happy to add it). Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/