Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266796AbUIMOKg (ORCPT ); Mon, 13 Sep 2004 10:10:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266802AbUIMOKg (ORCPT ); Mon, 13 Sep 2004 10:10:36 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:3309 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S266796AbUIMOK3 (ORCPT ); Mon, 13 Sep 2004 10:10:29 -0400 Date: Mon, 13 Sep 2004 16:10:17 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@scrub.home To: Hugh Dickins cc: Alex Zarochentsev , Paul Jackson , William Lee Irwin III , Hans Reiser , linux-kernel@vger.kernel.org, Andrew Morton , Martin Schwidefsky Subject: Re: 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 26 Hi, On Mon, 13 Sep 2004, Hugh Dickins wrote: > On Mon, 13 Sep 2004, Roman Zippel wrote: > > On Mon, 13 Sep 2004, Hugh Dickins wrote: > > > > > But Bill already said he doesn't want it, [...] > > > > > > - if (atomic_sub_and_test(bio->bi_vcnt, &fq->nr_submitted)) > > > + if (atomic_sub_return(bio->bi_vcnt, &fq->nr_submitted) == 0) > > > > And that is more portable how? > > It's more portable in that all but s390 already provide it > (and I expect Martin will be happy to add it). So why not add the missing atomic_sub_and_test() (using simply atomic_sub_return)? bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/