Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267466AbUIMPM3 (ORCPT ); Mon, 13 Sep 2004 11:12:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267660AbUIMPJT (ORCPT ); Mon, 13 Sep 2004 11:09:19 -0400 Received: from bay-bridge.veritas.com ([143.127.3.10]:37767 "EHLO MTVMIME02.enterprise.veritas.com") by vger.kernel.org with ESMTP id S267749AbUIMO72 (ORCPT ); Mon, 13 Sep 2004 10:59:28 -0400 Date: Mon, 13 Sep 2004 15:58:37 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@localhost.localdomain To: Roman Zippel cc: Alex Zarochentsev , Paul Jackson , William Lee Irwin III , Hans Reiser , , Andrew Morton , Martin Schwidefsky Subject: Re: 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 765 Lines: 20 On Mon, 13 Sep 2004, Roman Zippel wrote: > > So why not add the missing atomic_sub_and_test() (using simply > atomic_sub_return)? sparc and s390 are not the only arches lacking atomic_sub_and_test. Go ahead and send the patches changing all the arches that have it to define __ARCH_HAS_ATOMIC_SUB_AND_TEST, and add asm-generic/atomic.h for those that don't etc; but to me that seems like a waste of time - unless Zam convinces us that Reiser4 will need every last ounce of cpu on this particular line of code. Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/