Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268580AbUIMR2A (ORCPT ); Mon, 13 Sep 2004 13:28:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268733AbUIMR2A (ORCPT ); Mon, 13 Sep 2004 13:28:00 -0400 Received: from clusterfw.beelinegprs.com ([217.118.66.232]:4288 "EHLO crimson.namesys.com") by vger.kernel.org with ESMTP id S268580AbUIMR1h (ORCPT ); Mon, 13 Sep 2004 13:27:37 -0400 Date: Mon, 13 Sep 2004 21:19:36 +0400 From: Alex Zarochentsev To: Hugh Dickins Cc: Roman Zippel , Paul Jackson , William Lee Irwin III , Hans Reiser , linux-kernel@vger.kernel.org, Andrew Morton , Martin Schwidefsky Subject: Re: 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test Message-ID: <20040913171936.GC2252@backtop.namesys.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 31 On Mon, Sep 13, 2004 at 03:58:37PM +0100, Hugh Dickins wrote: > On Mon, 13 Sep 2004, Roman Zippel wrote: > > > > So why not add the missing atomic_sub_and_test() (using simply > > atomic_sub_return)? > > sparc and s390 are not the only arches lacking atomic_sub_and_test. > > Go ahead and send the patches changing all the arches that have it to > define __ARCH_HAS_ATOMIC_SUB_AND_TEST, and add asm-generic/atomic.h > for those that don't etc; but to me that seems like a waste of time - > unless Zam convinces us that Reiser4 will need every last ounce of I do not, Hans will ;-) I just like to know what atomic.h common functions would be in 2.6.9+, because nowdays the API is not consisent accross the arches. atomic_sub_return() is OK. > cpu on this particular line of code. > > Hugh -- Alex. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/