From: Jesse Barnes <jbarnes@engr.sgi.com>
To: "David S. Miller" <davem@davemloft.net>
Subject: Re: 2.6.9-rc1-mm5 bug in tcp_recvmsg?
Date: Mon, 13 Sep 2004 17:03:48 -0700
User-Agent: KMail/1.7
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
References: <20040913015003.5406abae.akpm@osdl.org> <200409131654.27727.jbarnes@engr.sgi.com> <20040913165557.568cdffb.davem@davemloft.net>
In-Reply-To: <20040913165557.568cdffb.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200409131703.48395.jbarnes@engr.sgi.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1131
Lines: 32

On Monday, September 13, 2004 4:55 pm, David S. Miller wrote:
> On Mon, 13 Sep 2004 16:54:27 -0700
>
> Jesse Barnes <jbarnes@engr.sgi.com> wrote:
> > tg3.  I saw one trace that included do_poll (iirc) and another last week
> > that had sys_select in it.  I'll try to gather some more info.
>
> What you're seeing might be due to the bug fixed by this patch:

>       spin_lock(&dev->queue_lock);
>       return -1;
>      }
> -    if (ret == NETDEV_TX_LOCKED && nolock)
> +    if (ret == NETDEV_TX_LOCKED && nolock) {
> +     spin_lock(&dev->queue_lock);
>       goto collision;
> +    }
>     }
>
>     /* NETDEV_TX_BUSY - we need to requeue */

Ok, I guess that would explain why I haven't seen this in 2.6.9-rc2.  I was 
getting my backtraces confused too--I've only seen this one for this bug.  
I'll keep an eye out and report anything I see with the latest bk tree.

Thanks,
Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/