Date: Wed, 15 Sep 2004 00:43:32 +0200
From: Marc Ballarin <Ballarin.Marc@gmx.de>
To: Peter Jones <pjones@redhat.com>
Cc: axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] allow root to modify raw scsi command permissions list
Message-Id: <20040915004332.6fe581f5.Ballarin.Marc@gmx.de>
In-Reply-To: <1095173470.5728.3.camel@localhost.localdomain>
References: <1095173470.5728.3.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1264
Lines: 40

On Tue, 14 Sep 2004 10:51:10 -0400
Peter Jones <pjones@redhat.com> wrote:

Good to see someone do this. I tried myself but didn't get very far.


> diff -urpN linux-2.5-export/drivers/block/genhd.c pjones-2.5-export/drivers/block/genhd.c
...

>  };
> +static struct disk_attribute disk_attribute_driver = {

This obviously needs to be

+static struct disk_attribute disk_attr_driver = {

otherwise the following part won't work:

> @@ -409,6 +422,7 @@ static struct attribute * default_attrs[
>  	&disk_attr_removable.attr,
>  	&disk_attr_size.attr,
>  	&disk_attr_stat.attr,
> +	&disk_attr_driver.attr,
>  	NULL,
>  };

Additionally, the naming "rawio_cmd_filter" and RCF_* seems a bit
confusing (after all raw IO usually refers to O_DIRECT file access).
"sg_cmd_filter" and SGF_* appear to be a better choice IMHO.

How should changes to the table be made? I suppose something like "echo
add 04 > ok_read_commands". But rcf_store doesn't seem to get called. Am I
missing something?

Regards, and thanks for this patch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/