Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266034AbUION1r (ORCPT ); Wed, 15 Sep 2004 09:27:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266149AbUION1r (ORCPT ); Wed, 15 Sep 2004 09:27:47 -0400 Received: from clock-tower.bc.nu ([81.2.110.250]:50881 "EHLO localhost.localdomain") by vger.kernel.org with ESMTP id S266034AbUION1h (ORCPT ); Wed, 15 Sep 2004 09:27:37 -0400 Subject: Re: [PATCH] DRM: add missing pci_enable_device() From: Alan Cox To: Jon Smirl Cc: Dave Airlie , Bjorn Helgaas , DRI Devel , Andrew Morton , Evan Paul Fletcher , Linux Kernel Mailing List In-Reply-To: <9e47339104091416416b9ae310@mail.gmail.com> References: <200409131651.05059.bjorn.helgaas@hp.com> <200409140845.59389.bjorn.helgaas@hp.com> <9e47339104091416416b9ae310@mail.gmail.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-Id: <1095250966.19930.25.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Wed, 15 Sep 2004 13:22:48 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 946 Lines: 20 On Mer, 2004-09-15 at 00:41, Jon Smirl wrote: > pci_enable/disable_device are correct in the dyn-minor patch. They > also appear to correct in the currently checked in DRM cvs. If fbdev > is loaded DRM does not do pci_enable/disable_device. It is assumed > that these calls are handled by the fbdev device. If you are calling pci_disable_device at all in the fb driver or DRI driver it is wrong, always wrong, always will be wrong for the main head. The video device is almost unique in that when you unload all the video drivers vgacon still owns and is using it. On some devices that needs PCI master enabled because of internal magic (like rendering text modes from the bios via SMM traps) Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/