Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266467AbUIOPfZ (ORCPT ); Wed, 15 Sep 2004 11:35:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266474AbUIOPfZ (ORCPT ); Wed, 15 Sep 2004 11:35:25 -0400 Received: from rproxy.gmail.com ([64.233.170.202]:56151 "EHLO mproxy.gmail.com") by vger.kernel.org with ESMTP id S266467AbUIOPfR (ORCPT ); Wed, 15 Sep 2004 11:35:17 -0400 Message-ID: <9e47339104091508354280713c@mail.gmail.com> Date: Wed, 15 Sep 2004 11:35:16 -0400 From: Jon Smirl Reply-To: Jon Smirl To: Alan Cox Subject: Re: [PATCH] DRM: add missing pci_enable_device() Cc: Dave Airlie , Bjorn Helgaas , DRI Devel , Andrew Morton , Evan Paul Fletcher , Linux Kernel Mailing List In-Reply-To: <1095250966.19930.25.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <200409131651.05059.bjorn.helgaas@hp.com> <200409140845.59389.bjorn.helgaas@hp.com> <9e47339104091416416b9ae310@mail.gmail.com> <1095250966.19930.25.camel@localhost.localdomain> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 25 On Wed, 15 Sep 2004 13:22:48 +0100, Alan Cox wrote: > On Mer, 2004-09-15 at 00:41, Jon Smirl wrote: > > pci_enable/disable_device are correct in the dyn-minor patch. They > > also appear to correct in the currently checked in DRM cvs. If fbdev > > is loaded DRM does not do pci_enable/disable_device. It is assumed > > that these calls are handled by the fbdev device. > > If you are calling pci_disable_device at all in the fb driver or DRI > driver it is wrong, always wrong, always will be wrong for the main > head. The video device is almost unique in that when you unload all > the video drivers vgacon still owns and is using it. On some devices > that needs PCI master enabled because of internal magic (like > rendering text modes from the bios via SMM traps) > How do I trigger this mode on a card supported by DRM so that we can test it? -- Jon Smirl jonsmirl@gmail.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/