Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267666AbUIOWNc (ORCPT ); Wed, 15 Sep 2004 18:13:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267660AbUIOWMF (ORCPT ); Wed, 15 Sep 2004 18:12:05 -0400 Received: from mail-relay-4.tiscali.it ([213.205.33.44]:30891 "EHLO mail-relay-4.tiscali.it") by vger.kernel.org with ESMTP id S267650AbUIOWJC (ORCPT ); Wed, 15 Sep 2004 18:09:02 -0400 Date: Thu, 16 Sep 2004 00:08:19 +0200 From: Andrea Arcangeli To: William Lee Irwin III Cc: Andrew Morton , linux-kernel@vger.kernel.org, an.li.wang@intel.com Subject: Re: truncate shows non zero data beyond the end of the inode with MAP_SHARED Message-ID: <20040915220819.GF15426@dualathlon.random> References: <20040915122920.GA4454@dualathlon.random> <20040915210106.GX9106@holomorphy.com> <20040915145524.079a8694.akpm@osdl.org> <20040915220016.GC9106@holomorphy.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040915220016.GC9106@holomorphy.com> X-GPG-Key: 1024D/68B9CB43 13D9 8355 295F 4823 7C49 C012 DFA1 686E 68B9 CB43 X-PGP-Key: 1024R/CB4660B9 CC A0 71 81 F4 A0 63 AC C0 4B 81 1D 8C 15 C8 E5 User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 21 On Wed, Sep 15, 2004 at 03:00:16PM -0700, William Lee Irwin III wrote: > William Lee Irwin III wrote: > >> Zeroing the final partial page during expanding truncate (flushing TLB) > >> sounds like a reasonable half measure; we don't do anything at the moment. > > On Wed, Sep 15, 2004 at 02:55:24PM -0700, Andrew Morton wrote: > > Sure about that? block_truncate_page() gets called. > > So it does; then the hard parts are what's biting aa. block_truncate_page is unrelated with this issue, it's called on the _new_ partial page generated by truncate, not on the _old_ partial page that is being extended to be a _full_ page (with garbage inside between the old_i_size and PAGE_ALIGN(old_i_size)). (again s/page/softblock/) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/