Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267703AbUIPGtm (ORCPT ); Thu, 16 Sep 2004 02:49:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267708AbUIPGtm (ORCPT ); Thu, 16 Sep 2004 02:49:42 -0400 Received: from mx2.elte.hu ([157.181.151.9]:11438 "EHLO mx2.elte.hu") by vger.kernel.org with ESMTP id S267703AbUIPGtk (ORCPT ); Thu, 16 Sep 2004 02:49:40 -0400 Date: Thu, 16 Sep 2004 08:51:01 +0200 From: Ingo Molnar To: Andi Kleen Cc: Andrew Morton , Zwane Mwaikambo , linux-kernel@vger.kernel.org, wli@holomorphy.com Subject: Re: [PATCH] remove LOCK_SECTION from x86_64 spin_lock asm Message-ID: <20040916065101.GA11726@elte.hu> References: <20040915144523.0fec2070.akpm@osdl.org> <20040916061359.GA12915@wotan.suse.de> <20040916062759.GA10527@elte.hu> <20040916064428.GD12915@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040916064428.GD12915@wotan.suse.de> User-Agent: Mutt/1.4.1i X-ELTE-SpamVersion: MailScanner 4.31.6-itk1 (ELTE 1.2) SpamAssassin 2.63 ClamAV 0.73 X-ELTE-VirusStatus: clean X-ELTE-SpamCheck: no X-ELTE-SpamCheck-Details: score=-4.9, required 5.9, autolearn=not spam, BAYES_00 -4.90 X-ELTE-SpamLevel: X-ELTE-SpamScore: -4 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 19 * Andi Kleen wrote: > I think the idea was that the spinlock functions should be small > enough that they don't have any stack local variables. [...] this might work for x64, but even there, are you sure it works even with CONFIG_PREEMPT enabled (there the spinlocks are more complex)? It sure wont work on x86 so i think we need a generic 'soft PC' solution. the alternative would be to unwind the stack - quite some task on some platforms ... Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/