Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267828AbUIPIKw (ORCPT ); Thu, 16 Sep 2004 04:10:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267829AbUIPIKv (ORCPT ); Thu, 16 Sep 2004 04:10:51 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:16907 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S267828AbUIPIKt (ORCPT ); Thu, 16 Sep 2004 04:10:49 -0400 Date: Thu, 16 Sep 2004 10:10:17 +0200 From: Adrian Bunk To: "Randy.Dunlap" Cc: mgreer@mvista.com, akpm , lkml Subject: Re: review MPSC driver Message-ID: <20040916081017.GA2167@fs.tum.de> References: <20040915150247.37706f7c.rddunlap@osdl.org> <20040915214301.53a68379.randy.dunlap@verizon.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040915214301.53a68379.randy.dunlap@verizon.net> User-Agent: Mutt/1.5.6+20040818i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 31 On Wed, Sep 15, 2004 at 09:43:01PM -0700, Randy.Dunlap wrote: > > | http://www.uwsg.iu.edu/hypermail/linux/kernel/0408.3/1549.html > > Hi Mark, >... > 3. + select SERIAL_CORE > + select SERIAL_CORE_CONSOLE > > Please don't use "select". Use "depends on" instead. >... That's a silly suggestion since none of these options are user visible. > ~Randy cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/