Subject: Re: Suspend2 Merge: e820 table support.
From: Nigel Cunningham <ncunningham@linuxmail.org>
Reply-To: ncunningham@linuxmail.org
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@digeo.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <20040916111438.GB5467@elf.ucw.cz>
References: <1095332590.3324.166.camel@laptop.cunninghams>
	 <20040916111438.GB5467@elf.ucw.cz>
Content-Type: text/plain
Message-Id: <1095333881.4932.194.camel@laptop.cunninghams>
Mime-Version: 1.0
Date: Thu, 16 Sep 2004 21:24:42 +1000
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1497
Lines: 53

Hi.

On Thu, 2004-09-16 at 21:14, Pavel Machek wrote:
> Please, do not put ifdefs around #includes and statements like

Ah. Sorry. Will correct.

> ClearPageNosave. (And is it neccessary at all? I'd just say that all
> pages that are Reserved are Nosave automatically.)

Hmm. Long time since I thought about that. I'll check.

> > +#ifdef CONFIG_SOFTWARE_SUSPEND2
> > +			/*
> > +			 * Mark nosave pages
> > +			 */
> > +			if (addr >= (void *)&__nosave_begin && addr < (void *)&__nosave_end)
> > +				SetPageNosave(mem_map+tmp);
> > +		} else
> > +			/*
> > +			 * Non-RAM pages are always nosave
> > +			 */
> > +			SetPageNosave(mem_map+tmp);
> > +#else
> > +		}
> > +#endif
> > +	}
> 
> Current -mm code does something funny with Nosave; I'm not sure it
> will not try to free them after resume. I have fix in my tree but it
> is little tested.

Double negative: you think current mm may try to free Nosave pages after
resume? I haven't updated to the latest -mm yet, but will see if I can
try tomorrow.

Thanks for the feedback.

Nigel
-- 
Nigel Cunningham
Pastoral Worker
Christian Reformed Church of Tuggeranong
PO Box 1004, Tuggeranong, ACT 2901

Many today claim to be tolerant. True tolerance, however, can cope with others
being intolerant.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/