Subject: Re: [PATCH] Suspend2 merge: New exports.
From: Nigel Cunningham <ncunningham@linuxmail.org>
Reply-To: ncunningham@linuxmail.org
To: arjanv@redhat.com
Cc: Andrew Morton <akpm@digeo.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <1095334846.2698.13.camel@laptop.fenrus.com>
References: <1095333619.3327.189.camel@laptop.cunninghams>
	 <1095334846.2698.13.camel@laptop.fenrus.com>
Content-Type: text/plain
Message-Id: <1095335648.4883.230.camel@laptop.cunninghams>
Mime-Version: 1.0
Date: Thu, 16 Sep 2004 21:54:09 +1000
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1092
Lines: 37

Hi.

On Thu, 2004-09-16 at 21:40, Arjan van de Ven wrote:
> On Thu, 2004-09-16 at 13:20, Nigel Cunningham wrote:
> 
> >  
> > +EXPORT_SYMBOL(tainted);
> 
> uhhhhh why do you need this in a module ?????
> 
> most of these exports look REALLY fishy to me.

I'm marking the kernel as tainted when we've suspended. It could
probably be dropped but I was erring on the side of paranoia.

As to the others, I'll be happy to explain how they're used and drop
them if necessary/possible. I agree about a couple. The keyboard sound
one, for example, slipped past my purge of some
report-progress-while-beeping code I inherited.

Regards,

Nigel
-- 
Nigel Cunningham
Pastoral Worker
Christian Reformed Church of Tuggeranong
PO Box 1004, Tuggeranong, ACT 2901

Many today claim to be tolerant. True tolerance, however, can cope with others
being intolerant.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/