Subject: Re: Suspend2 Merge: e820 table support.
From: Nigel Cunningham <ncunningham@linuxmail.org>
Reply-To: ncunningham@linuxmail.org
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@digeo.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <20040916113735.GG5467@elf.ucw.cz>
References: <1095332590.3324.166.camel@laptop.cunninghams>
	 <20040916111438.GB5467@elf.ucw.cz>
	 <1095333881.4932.194.camel@laptop.cunninghams>
	 <20040916112711.GD5467@elf.ucw.cz>
	 <1095334545.4932.206.camel@laptop.cunninghams>
	 <20040916113735.GG5467@elf.ucw.cz>
Content-Type: text/plain
Message-Id: <1095335962.5006.241.camel@laptop.cunninghams>
Mime-Version: 1.0
Date: Thu, 16 Sep 2004 21:59:26 +1000
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1455
Lines: 44

Hi.

On Thu, 2004-09-16 at 21:37, Pavel Machek wrote:
> Hi!
> 
> > > Hmm, it also contains (saveable()):
> > > 
> > >         BUG_ON(PageReserved(page) && PageNosave(page));
> > 
> > How do you cover those HighMem pages that get marked Reserved and are
> > unusable? (That's what the e820 logic was for, iirc. Think it was done
> > about February!). Not handling them resulted in MCEs when trying to do
> > the atomic copy or when restoring (seemed random).
> 
> This function is not use for highmem, AFAICS. If page is marked
> reserved we do not touch it. Do you suggest that we need to save it
> for highmem case?

I love trying to remember things from six months ago. Will have to look
at the email from around then and get back to you.

> MCEs... I see you have patch to disable them during suspend... That's
> clearly wrong thing to do, right?

Yes, we shouldn't need to disable them if we have above right. I'll test
removing that with some of the people who had MCE issues.

Regards,

Nigel
-- 
Nigel Cunningham
Pastoral Worker
Christian Reformed Church of Tuggeranong
PO Box 1004, Tuggeranong, ACT 2901

Many today claim to be tolerant. True tolerance, however, can cope with others
being intolerant.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/