Date: Thu, 16 Sep 2004 14:21:09 +0200
From: Marc Ballarin <Ballarin.Marc@gmx.de>
To: Peter Jones <pjones@redhat.com>
Cc: alan@lxorguk.ukuu.org.uk, axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH-NEW] allow root to modify raw scsi command permissions
 list
Message-Id: <20040916142109.6fc7223c.Ballarin.Marc@gmx.de>
In-Reply-To: <1095291378.5945.4.camel@localhost.localdomain>
References: <1095173470.5728.3.camel@localhost.localdomain>
	<20040915230813.6eac1d04.Ballarin.Marc@gmx.de>
	<1095284325.20749.8.camel@localhost.localdomain>
	<20040916013351.1422170f.Ballarin.Marc@gmx.de>
	<1095291378.5945.4.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 850
Lines: 30

On Wed, 15 Sep 2004 19:36:18 -0400
Peter Jones <pjones@redhat.com> wrote:

> Yes.
> 
> Here's another version of the patch.  It does what yours did, as well as
> that.  It also combines the read and write code so there's one of each,
> with a parameter to tell which it's supposed to modify.

Looks *slightly* better than mine ;-)

But

> +static ssize_t rcf_cmds_store(struct rawio_cmd_filter *rcf, const char *page,
> +			size_t count, int rw)
	...
> +		ss.from = (char *)page+ret;
> +		ss.to = (char *)page+ret+1;

needs to be

> +		ss.from = (char *)page+ret;
> +		ss.to = (char *)page+ret+2;

Regards
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/