Date: Thu, 16 Sep 2004 07:28:48 -0700
From: Greg KH <greg@kroah.com>
To: Nigel Cunningham <ncunningham@linuxmail.org>
Cc: Andrew Morton <akpm@digeo.com>, Patrick Mochel <mochel@digitalimplant.org>,
       Pavel Machek <pavel@ucw.cz>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Suspend2 Merge: Driver model patches 2/2
Message-ID: <20040916142847.GA32352@kroah.com>
References: <1095332331.3855.161.camel@laptop.cunninghams>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1095332331.3855.161.camel@laptop.cunninghams>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1022
Lines: 33

On Thu, Sep 16, 2004 at 08:58:51PM +1000, Nigel Cunningham wrote:
> 
> This simple helper adds support for finding a class given its name. I
> use this to locate the frame buffer drivers and move them to the
> keep-alive tree while suspending other drivers.
> 
> +struct class * class_find(char * name)
> +{
> +	struct class * this_class;
> +
> +	if (!name)
> +		return NULL;
> +
> +	list_for_each_entry(this_class, &class_subsys.kset.list, subsys.kset.kobj.entry) {
> +		if (!(strcmp(this_class->name, name)))
> +			return this_class;
> +	}
> +
> +	return NULL;
> +}

Ick, no.  I've been over this before with the fb people, and am not going
to accept this patch (nevermind that it's broken...)  See the lkml
archives for more info on why I don't like this.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/