Date: Thu, 16 Sep 2004 08:21:35 -0700
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Adrian Bunk <bunk@fs.tum.de>, mk+lkml@arm.linux.org.uk
Cc: mgreer@mvista.com, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: review MPSC driver
Message-Id: <20040916082135.7cde3b32.rddunlap@osdl.org>
In-Reply-To: <20040916081017.GA2167@fs.tum.de>
References: <20040915150247.37706f7c.rddunlap@osdl.org>
	<20040915214301.53a68379.randy.dunlap@verizon.net>
	<20040916081017.GA2167@fs.tum.de>
Organization: OSDL
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 973
Lines: 30

On Thu, 16 Sep 2004 10:10:17 +0200 Adrian Bunk wrote:

| On Wed, Sep 15, 2004 at 09:43:01PM -0700, Randy.Dunlap wrote:
| > 
| > | http://www.uwsg.iu.edu/hypermail/linux/kernel/0408.3/1549.html
| > 
| > Hi Mark,
| >...
| > 3.  + select SERIAL_CORE
| >     + select SERIAL_CORE_CONSOLE
| > 
| > Please don't use "select".  Use "depends on" instead.
| >...
| 
| That's a silly suggestion since none of these options are user visible.

and Russell King wrote about the same text:
| This is actually (one of the few) correct uses of select.  These two
| symbols are *not* user visible, and are derived from the configuration
| settings of the hardware drivers.

Thanks for your comments.  Any other comments on the driver?

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/