Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268527AbUIQHYI (ORCPT ); Fri, 17 Sep 2004 03:24:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268529AbUIQHYH (ORCPT ); Fri, 17 Sep 2004 03:24:07 -0400 Received: from imladris.demon.co.uk ([193.237.130.41]:55565 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S268527AbUIQHX6 (ORCPT ); Fri, 17 Sep 2004 03:23:58 -0400 Date: Fri, 17 Sep 2004 08:23:44 +0100 From: Christoph Hellwig To: Nigel Cunningham Cc: Andrew Morton , Patrick Mochel , Pavel Machek , Linux Kernel Mailing List Subject: Re: [PATCH] Suspend2 Merge: Driver model patches 1/2 Message-ID: <20040917082344.B10537@infradead.org> Mail-Followup-To: Christoph Hellwig , Nigel Cunningham , Andrew Morton , Patrick Mochel , Pavel Machek , Linux Kernel Mailing List References: <1095332323.3855.159.camel@laptop.cunninghams> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <1095332323.3855.159.camel@laptop.cunninghams>; from ncunningham@linuxmail.org on Thu, Sep 16, 2004 at 08:58:44PM +1000 X-SRS-Rewrite: SMTP reverse-path rewritten from by phoenix.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 760 Lines: 18 > +struct partial_device_tree default_device_tree = > +{ > + .dpm_active = LIST_HEAD_INIT(default_device_tree.dpm_active), > + .dpm_off = LIST_HEAD_INIT(default_device_tree.dpm_off), > + .dpm_off_irq = LIST_HEAD_INIT(default_device_tree.dpm_off_irq), > +}; > +EXPORT_SYMBOL(default_device_tree); _never_ exports lists, only accessory funktions. But honestly please get some builtin code merged first, then think about making it modular. We don't want to add random exports just to see them never used later on. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/