Date: Fri, 17 Sep 2004 18:01:00 +0200
From: Andrea Arcangeli <andrea@novell.com>
To: Stelian Pop <stelian@popies.net>, James R Bruce <bruce@andrew.cmu.edu>,
       Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org,
       Hugh Dickins <hugh@veritas.com>
Subject: Re: [RFC, 2.6] a simple FIFO implementation
Message-ID: <20040917160100.GZ15426@dualathlon.random>
References: <20040913135253.GA3118@crusoe.alcove-fr> <20040915153013.32e797c8.akpm@osdl.org> <20040916064320.GA9886@deep-space-9.dsnet> <20040916000438.46d91e94.akpm@osdl.org> <Pine.LNX.4.60-041.0409170823140.1298@unix48.andrew.cmu.edu> <20040917154834.GA3180@crusoe.alcove-fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040917154834.GA3180@crusoe.alcove-fr>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 713
Lines: 30

On Fri, Sep 17, 2004 at 05:48:35PM +0200, Stelian Pop wrote:
> +	/* verify that size is a power of 2 */
> +	newsize = 1;
> +	while (newsize < size)
> +		newsize <<= 1;
> +	if (newsize != size)
> +		return NULL;

I think you mean:

	BUG_ON(size & (size-1));

;)

> +	fifo = kmalloc(sizeof(struct kfifo), gfp_mask);
> +	if (!fifo)
> +		return NULL;

this could be ERR_PTR(-ENOMEM).

> +	buffer = kmalloc(newsize, gfp_mask);
> +	if (!buffer)
> +		return NULL;

same here.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/