Date: Sun, 19 Sep 2004 23:49:20 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Karsten Wiese <annabellesgarden@yahoo.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] voluntary-preempt-2.6.9-rc2-mm1-S1
Message-ID: <20040919214920.GA8616@elte.hu>
References: <200409192232.20139.annabellesgarden@yahoo.de> <20040919204841.GA7004@elte.hu> <200409192311.37639.annabellesgarden@yahoo.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200409192311.37639.annabellesgarden@yahoo.de>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 957
Lines: 28


* Karsten Wiese <annabellesgarden@yahoo.de> wrote:

> Am Sonntag 19 September 2004 22:48 schrieb Ingo Molnar:
> >
> > The point is to let gettimeofday(0,1) start tracing and
> > gettimeofday(0,0) stop tracing - a system-call-controlled tracing
> > facility (if trace_enabled=2). This was used to trace weird latencies
> > before, but it's not the normal mode of operation.
> >
> Ok. The other point is a page_fault being generated later on in 
> sys_gettimeofday() if tz is not reset:
> >>>>
> 	if (unlikely(tz != NULL)) {
>                      ^^
> 		if (copy_to_user(tz, &sys_tz, sizeof(sys_tz)))
> 			return -EFAULT;
> 	}
> <<<<

yeah - it's a bit ugly. The right thing is to return from that branch.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/