Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266175AbUITJUs (ORCPT ); Mon, 20 Sep 2004 05:20:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266181AbUITJUs (ORCPT ); Mon, 20 Sep 2004 05:20:48 -0400 Received: from hirsch.in-berlin.de ([192.109.42.6]:50363 "EHLO hirsch.in-berlin.de") by vger.kernel.org with ESMTP id S266175AbUITJUh (ORCPT ); Mon, 20 Sep 2004 05:20:37 -0400 X-Envelope-From: kraxel@bytesex.org To: Nishanth Aravamudan Cc: Andrew Morton , Kernel List Subject: Re: [patch] v4l: bttv update References: <20040916091505.GA11528@bytesex> <20040917225105.GA11971@us.ibm.com> From: Gerd Knorr Organization: SUSE Labs, Berlin Date: 20 Sep 2004 11:11:33 +0200 In-Reply-To: <20040917225105.GA11971@us.ibm.com> Message-ID: <87hdpt1f0a.fsf@bytesex.org> User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 20 Nishanth Aravamudan writes: > > - set_current_state(TASK_INTERRUPTIBLE); > > - schedule_timeout(HZ/50); > > + msleep(10); > > My original patch used > > msleep(20); > > Is there a reason the conversion was changed? Doesn't really matter. The code just polls in a loop until the status register says the pll is locked. Usually it needs one round only, so the delay can be smaller to make the function return earlier ;) Gerd -- return -ENOSIG; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/