Date: Mon, 20 Sep 2004 21:01:34 +0300
From: Sasha Khapyorsky <sashak@smlink.com>
To: Stelian Pop <stelian@popies.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC, 2.6] a simple FIFO implementation
Message-ID: <20040920210134.0b4af72c@sashak.lan>
In-Reply-To: <20040920151425.GA3020@crusoe.alcove-fr>
References: <20040917154834.GA3180@crusoe.alcove-fr>
	<Pine.LNX.4.44.0409171708210.3162-100000@localhost.localdomain>
	<20040917205011.GA3049@crusoe.dsnet>
	<20040917212847.GC15426@dualathlon.random>
	<20040920151425.GA3020@crusoe.alcove-fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 901
Lines: 27

On Mon, 20 Sep 2004 17:14:26 +0200
Stelian Pop <stelian@popies.net> wrote:

> +unsigned int __kfifo_get(struct kfifo *fifo, 
> +			 unsigned char *buffer, unsigned int len)
> +{
> +	unsigned int l;
> +
> +	len = min(len, fifo->in - fifo->out);
> +
> +	/* first get the data from fifo->out until the end of the buffer */
> +	l = min(len, fifo->size - (fifo->out & (fifo->size - 1)));
> +	memcpy(buffer, fifo->buffer + (fifo->out & (fifo->size - 1)), l);
> +
> +	/* then get the rest (if any) from the beginning of the buffer */
> +	memcpy(buffer, fifo->buffer + l, len - l);

I guess last line should be:

  memcpy(buffer + l, fifo->buffer, len - i)

Sasha.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/