Date: Mon, 20 Sep 2004 19:07:21 -0400 (EDT)
From: James Morris <jmorris@redhat.com>
To: Will Dyson <will.dyson@gmail.com>
cc: Andrew Morton <akpm@osdl.org>, <viro@parcelfarce.linux.theplanet.co.uk>,
       Stephen Smalley <sds@epoch.ncsc.mil>,
       Christoph Hellwig <hch@infradead.org>,
       Andreas Gruenbacher <agruen@suse.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] xattr consolidation v2 - generic xattr API
In-Reply-To: <8e6f9472040920105013b4e0cd@mail.gmail.com>
Message-ID: <Xine.LNX.4.44.0409201904220.23206-100000@thoron.boston.redhat.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1260
Lines: 35

On Mon, 20 Sep 2004, Will Dyson wrote:

> I don't plan on holding my breath while waiting for "The linux vfs
> layer for dummies" to come out. But a quick comment to explain the
> purpose and use of a block of code can make a world of difference to
> someone trying to come up to speed.

If you want to supply documentation patches, please feel free to do so.

> For example:
> 
> /*
> In order to implement different sets of xattr operations for each
> xattr prefix, a filesystem should create a null-terminated array of
> struct xattr_handler (one for each prefix) and hang a pointer to it
> off of the s_xattr field of the superblock. The generic_fooxattr
> functions will search this list for a xattr_handler with a prefix
> field that matches the prefix of the xattr we are dealing with and
> call the apropriate function pointer from that xattr_handler.
> */

The above is inaccurate.  e.g. not all of the generic functions search for
a matching xattr handler.


- James
-- 
James Morris
<jmorris@redhat.com>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/