Date: Tue, 21 Sep 2004 11:12:16 -0500
To: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Cc: paulus@samba.org, linux-kernel@vger.kernel.org, anton@samba.org
Subject: Re: [PATCH] [PPC64] [TRIVIAL] Janitor whitespace in pSeries_pci.c
Message-ID: <20040921161216.GD1872@austin.ibm.com>
References: <20040920221933.GB1872@austin.ibm.com> <20040920223121.GC1872@austin.ibm.com> <200409211407.09764.vda@port.imtp.ilyichevsk.odessa.ua>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200409211407.09764.vda@port.imtp.ilyichevsk.odessa.ua>
User-Agent: Mutt/1.5.6+20040818i
From: Linas Vepstas <linas@austin.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1237
Lines: 33

On Tue, Sep 21, 2004 at 02:07:09PM +0300, Denis Vlasenko was heard to remark:
> On Tuesday 21 September 2004 01:31, Linas Vepstas wrote:
> > 
> > Forgot to attach the actual patch.
> > 
> > On Mon, Sep 20, 2004 at 05:19:33PM -0500, Linas Vepstas was heard to remark:
> > > Hi,
> > 
> > 
> > This file mixes tabs with 8 spaces, leading to poor display 
> > if one's editor doesn't have tab-stops set to 8.   Please apply.
> 
> There are lots of such places.
> Automated scripts can easily produce megabytes worth of whitespace
> patches.
> 
> As I understand, such patches aren't accepted because
> merging pain is much greater than gain.
> Typically whitespace cleanups are piggybacked on some code changes.

Last time I sent in a combined whitespace plus other-fixes patch, 
I was asked to do the opposite, and split them apart.  I'm just
trying to do the right thing; I have other pending patches for this 
file, and I'm waiting for the backlog to clear out before I submit
those.

--linas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/