Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266048AbUIWUUa (ORCPT ); Thu, 23 Sep 2004 16:20:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264954AbUIWUU3 (ORCPT ); Thu, 23 Sep 2004 16:20:29 -0400 Received: from baikonur.stro.at ([213.239.196.228]:47490 "EHLO baikonur.stro.at") by vger.kernel.org with ESMTP id S266048AbUIWUTq (ORCPT ); Thu, 23 Sep 2004 16:19:46 -0400 Subject: [patch 3/5] pcmcia/ds: replace schedule_timeout() with msleep() To: akpm@digeo.com Cc: linux-kernel@vger.kernel.org, janitor@sternwelten.at, nacc@us.ibm.com From: janitor@sternwelten.at Date: Thu, 23 Sep 2004 22:19:47 +0200 Message-ID: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1847 Lines: 63 I would appreciate any comments from the janitor@sternweltens list. This is one (of many) cases where I made a decision about replacing set_current_state(TASK_INTERRUPTIBLE); schedule_timeout(some_time); with msleep(jiffies_to_msecs(some_time)); msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch. Thanks, Nish Description: Uses msleep() instead of schedule_timeout() to guarantee the task delays the desired time. Signed-off-by: Nishanth Aravamudan Signed-off-by: Maximilian Attems --- linux-2.6.9-rc2-bk7-max/drivers/pcmcia/ds.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/pcmcia/ds.c~msleep-drivers_pcmcia_ds drivers/pcmcia/ds.c --- linux-2.6.9-rc2-bk7/drivers/pcmcia/ds.c~msleep-drivers_pcmcia_ds 2004-09-21 20:51:16.000000000 +0200 +++ linux-2.6.9-rc2-bk7-max/drivers/pcmcia/ds.c 2004-09-21 20:51:16.000000000 +0200 @@ -50,6 +50,7 @@ #include #include #include +#include #include #include @@ -1080,8 +1081,7 @@ static int __devinit pcmcia_bus_add_sock * Ugly. But we want to wait for the socket threads to have started up. * We really should let the drivers themselves drive some of this.. */ - current->state = TASK_INTERRUPTIBLE; - schedule_timeout(HZ/4); + msleep(250); init_waitqueue_head(&s->queue); init_waitqueue_head(&s->request); _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/