Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267304AbUIWUhp (ORCPT ); Thu, 23 Sep 2004 16:37:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266808AbUIWUhM (ORCPT ); Thu, 23 Sep 2004 16:37:12 -0400 Received: from baikonur.stro.at ([213.239.196.228]:61855 "EHLO baikonur.stro.at") by vger.kernel.org with ESMTP id S266820AbUIWUZi (ORCPT ); Thu, 23 Sep 2004 16:25:38 -0400 Subject: [patch 16/26] char/pcxx: replace schedule_timeout() with msleep_interruptible() To: akpm@digeo.com Cc: linux-kernel@vger.kernel.org, janitor@sternwelten.at, nacc@us.ibm.com, christoph@lameter.com From: janitor@sternwelten.at Date: Thu, 23 Sep 2004 22:25:38 +0200 Message-ID: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1317 Lines: 37 Any comments would be appreciated. Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. Signed-off-by: Nishanth Aravamudan Looks fine to me. Signed-off-by: Christoph Lameter Signed-off-by: Maximilian Attems --- linux-2.6.9-rc2-bk7-max/drivers/char/pcxx.c | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) diff -puN drivers/char/pcxx.c~msleep_interruptible-drivers_char_pcxx drivers/char/pcxx.c --- linux-2.6.9-rc2-bk7/drivers/char/pcxx.c~msleep_interruptible-drivers_char_pcxx 2004-09-21 21:08:15.000000000 +0200 +++ linux-2.6.9-rc2-bk7-max/drivers/char/pcxx.c 2004-09-21 21:08:15.000000000 +0200 @@ -555,8 +555,7 @@ static void pcxe_close(struct tty_struct #endif if(info->blocked_open) { if(info->close_delay) { - current->state = TASK_INTERRUPTIBLE; - schedule_timeout(info->close_delay); + msleep_interruptible(jiffies_to_msecs(info->close_delay)); } wake_up_interruptible(&info->open_wait); } _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/