Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267403AbUIWWnH (ORCPT ); Thu, 23 Sep 2004 18:43:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267482AbUIWWj5 (ORCPT ); Thu, 23 Sep 2004 18:39:57 -0400 Received: from bart.webpack.hosteurope.de ([217.115.142.76]:47843 "EHLO bart.webpack.hosteurope.de") by vger.kernel.org with ESMTP id S267403AbUIWWhV (ORCPT ); Thu, 23 Sep 2004 18:37:21 -0400 Date: Fri, 24 Sep 2004 00:37:27 +0200 (CEST) From: Martin Diehl X-X-Sender: martin@notebook.home.mdiehl.de To: Andrew Morton cc: linux-kernel@vger.kernel.org Subject: 2.6.9-rc2-mm2: devmem_is_allowed Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-HE-MXrcvd: no Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1120 Lines: 34 Hi, after switching from working 2.6.9-rc2 to -mm2, X refused to start on my testbox. It turned out this was because it failed (EPERM) reading from /dev/mem beyond the 1MB limit. IMHO there is a typo in the test in devmem_is_allowed. The patch below fixed the issue for me. Despite I think it's pretty clear the logic there needs to be reverted, I'm somewhat uncertain because AFAICS nobody else complained so far - did I miss something? Martin ------------- diff -urp linux-2.6.9-rc2-mm2/arch/i386/mm/init.c v2.6.9-rc2-mm2-md/arch/i386/mm/init.c --- linux-2.6.9-rc2-mm2/arch/i386/mm/init.c Thu Sep 23 11:41:20 2004 +++ v2.6.9-rc2-mm2-md/arch/i386/mm/init.c Fri Sep 24 00:13:26 2004 @@ -239,7 +239,7 @@ int devmem_is_allowed(unsigned long page { if (pagenr <= 256) return 1; - if (!page_is_ram(pagenr)) + if (page_is_ram(pagenr)) return 1; return 0; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/