Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266768AbUIXCJ5 (ORCPT ); Thu, 23 Sep 2004 22:09:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266753AbUIWUkR (ORCPT ); Thu, 23 Sep 2004 16:40:17 -0400 Received: from baikonur.stro.at ([213.239.196.228]:25224 "EHLO baikonur.stro.at") by vger.kernel.org with ESMTP id S266741AbUIWUZS (ORCPT ); Thu, 23 Sep 2004 16:25:18 -0400 Subject: [patch 09/26] char/hvc_console: replace schedule_timeout() with msleep_interruptible() To: akpm@digeo.com Cc: linux-kernel@vger.kernel.org, janitor@sternwelten.at, nacc@us.ibm.com, R.E.Wolff@BitWizard.nl From: janitor@sternwelten.at Date: Thu, 23 Sep 2004 22:25:18 +0200 Message-ID: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1681 Lines: 54 Any comments would be appreciated. Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. Signed-off-by: Nishanth Aravamudan Looks good. Signed-off-by: Rogier Wolff Signed-off-by: Maximilian Attems --- linux-2.6.9-rc2-bk7-max/drivers/char/hvc_console.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff -puN drivers/char/hvc_console.c~msleep_interruptible-drivers_char_hvc_console drivers/char/hvc_console.c --- linux-2.6.9-rc2-bk7/drivers/char/hvc_console.c~msleep_interruptible-drivers_char_hvc_console 2004-09-21 21:08:07.000000000 +0200 +++ linux-2.6.9-rc2-bk7-max/drivers/char/hvc_console.c 2004-09-21 21:08:07.000000000 +0200 @@ -37,6 +37,7 @@ #include #include #include +#include #include #include #include @@ -44,7 +45,7 @@ #define HVC_MAJOR 229 #define HVC_MINOR 0 -#define TIMEOUT ((HZ + 99) / 100) +#define TIMEOUT (10) /* * Wait this long per iteration while trying to push buffered data to the @@ -610,7 +611,7 @@ int khvcd(void *unused) if (poll_mask == 0) schedule(); else - schedule_timeout(TIMEOUT); + msleep_interruptible(TIMEOUT); } __set_current_state(TASK_RUNNING); } while (!kthread_should_stop()); _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/