Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266845AbUIWUhs (ORCPT ); Thu, 23 Sep 2004 16:37:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266837AbUIWUhF (ORCPT ); Thu, 23 Sep 2004 16:37:05 -0400 Received: from baikonur.stro.at ([213.239.196.228]:22215 "EHLO baikonur.stro.at") by vger.kernel.org with ESMTP id S266808AbUIWUZf (ORCPT ); Thu, 23 Sep 2004 16:25:35 -0400 Subject: [patch 15/26] char/mxser: replace schedule_timeout() with msleep_interruptible() To: akpm@digeo.com Cc: linux-kernel@vger.kernel.org, janitor@sternwelten.at, nacc@us.ibm.com From: janitor@sternwelten.at Date: Thu, 23 Sep 2004 22:25:35 +0200 Message-ID: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 43 Any comments would be appreciated. Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. Signed-off-by: Nishanth Aravamudan Signed-off-by: Maximilian Attems --- linux-2.6.9-rc2-bk7-max/drivers/char/mxser.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/char/mxser.c~msleep_interruptible-drivers_char_mxser drivers/char/mxser.c --- linux-2.6.9-rc2-bk7/drivers/char/mxser.c~msleep_interruptible-drivers_char_mxser 2004-09-21 21:08:14.000000000 +0200 +++ linux-2.6.9-rc2-bk7-max/drivers/char/mxser.c 2004-09-21 21:08:14.000000000 +0200 @@ -59,6 +59,7 @@ #include #include #include +#include #include #include @@ -820,8 +821,7 @@ static void mxser_close(struct tty_struc info->tty = NULL; if (info->blocked_open) { if (info->close_delay) { - set_current_state(TASK_INTERRUPTIBLE); - schedule_timeout(info->close_delay); + msleep_interruptible(jiffies_to_msecs(info->close_delay)); } wake_up_interruptible(&info->open_wait); } _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/