Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266871AbUIXDfL (ORCPT ); Thu, 23 Sep 2004 23:35:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266903AbUIXDbt (ORCPT ); Thu, 23 Sep 2004 23:31:49 -0400 Received: from relay.pair.com ([209.68.1.20]:33797 "HELO relay.pair.com") by vger.kernel.org with SMTP id S267259AbUIXDaz (ORCPT ); Thu, 23 Sep 2004 23:30:55 -0400 X-pair-Authenticated: 66.188.111.210 Message-ID: <415394EE.50106@cybsft.com> Date: Thu, 23 Sep 2004 22:30:54 -0500 From: "K.R. Foley" User-Agent: Mozilla Thunderbird 0.8 (X11/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "K.R. Foley" CC: Ingo Molnar , linux-kernel@vger.kernel.org, Lee Revell , Mark_H_Johnson@Raytheon.com, Rui Nuno Capela Subject: Re: [patch] voluntary-preempt-2.6.9-rc2-mm3-S5 References: <1094597988.16954.212.camel@krustophenia.net> <20040908082050.GA680@elte.hu> <1094683020.1362.219.camel@krustophenia.net> <20040909061729.GH1362@elte.hu> <20040919122618.GA24982@elte.hu> <414F8CFB.3030901@cybsft.com> <20040921071854.GA7604@elte.hu> <20040921074426.GA10477@elte.hu> <20040922103340.GA9683@elte.hu> <20040923122838.GA9252@elte.hu> <20040923211206.GA2366@elte.hu> <415384E1.2080907@cybsft.com> In-Reply-To: <415384E1.2080907@cybsft.com> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1664 Lines: 48 K.R. Foley wrote: > Ingo Molnar wrote: > >> i've released the -S5 VP patch: >> >> >> http://redhat.com/~mingo/voluntary-preempt/voluntary-preempt-2.6.9-rc2-mm3-S5 >> > > > This one seems to bring back some issues with the network interface. The > only noticeable symptom is dropping ~30 percent of new telnet > connections under heavy load. When not loaded it still drops ~5 percent. > I had no dropped connections with S4 even when loaded. This just happens > to be one of things that I have been testing manually since I noticed > some problems with previous patches. > > Currently using an SMC card with a DEC 21140 chip and the tulip driver > on my SMP system. > > kr The following, on top of Ingo's patch above, fixes the problem with dropping new connections and doesn't have any adverse affects that I've seen: --- linux-2.6.9-rc2-pre-mm3/net/ipv4/tcp_output.c.orig 2004-09-23 22:16:42.249435870 -0500 +++ linux-2.6.9-rc2-pre-mm3/net/ipv4/tcp_output.c 2004-09-23 22:12:03.911811945 -0500 @@ -699,11 +699,6 @@ tcp_minshall_update(tp, mss_now, skb); sent_pkts = 1; - /* - * Break out early - we'll continue later: - */ - if (softirq_need_resched()) - break; } if (sent_pkts) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/