Message-ID: <4154083B.6040109@ppp0.net>
Date: Fri, 24 Sep 2004 13:42:51 +0200
From: Jan Dittmer <jdittmer@ppp0.net>
User-Agent: Mozilla Thunderbird 0.7.3 (X11/20040830)
MIME-Version: 1.0
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
CC: linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>,
       Hotplug List <pcihpd-discuss@lists.sourceforge.net>
Subject: Re: Is there a user space pci rescan method?
References: <E8F8DBCB0468204E856114A2CD20741F2C13E2@mail.local.ActualitySystems.com> <4152FFA0.9020005@ppp0.net> <200409231905.47279@bilbo.math.uni-mannheim.de> <200409241241.19654@bilbo.math.uni-mannheim.de>
In-Reply-To: <200409241241.19654@bilbo.math.uni-mannheim.de>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1638
Lines: 31

Rolf Eike Beer wrote:
> Ok, here we go. This is my current diff that I use for my tests at home. It adds
> dummyphp and cleans up fakephp a lot (read: kills it). Changes from last version:
> 
> -removed some dead comments
> -removed some unused instructions
> -reordered allocation in add_slot to do less memory allocations if there is
>  no device in slot
> -changed param "usedonly" to "showunused" so it behaves like fakephp at the
>  first look: if you load dummyphp without parameters there are only slots with
>  devices in it.
> -removed "DUMMY-" prefix to entries in /sys/bus/pci/slots/
> 
> Please send comments so I can send it for inclusion soon.

Well, first of all I think you should just submit a patch to add dummyphp and not
removing fakephp in the same step. Also you somehow mis-copied the patch to
your mail app - most (not all) tabs are converted to one space (or is it just
thunderbird displaying the mail?). Can you resend it? Then I'll give it a try.
Greg wrote in another mail that the 'proper' way of 'powering up' device slots should
be to rescan the entire bus. I don't know, your approach certainly seems easier, but you
are bound to either display all pci slots which may come to live or just the ones
in the system already, which means you cannot rescan slots which weren't equipped
on boot up. So perhaps adding a rescan method to fakephp is indeed cleaner.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/