Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Subject: RE: suspend/resume support for driver requires an external firmware
Date: Fri, 24 Sep 2004 23:03:02 +0800
Message-ID: <3ACA40606221794F80A5670F0AF15F8403BD578D@pdsmsx403>
Thread-Topic: suspend/resume support for driver requires an external firmware
Thread-Index: AcSiCMzRPTYS/lheRpG9AJQ6XOrbpQAPab2Q
From: "Zhu, Yi" <yi.zhu@intel.com>
To: "Patrick Mochel" <mochel@digitalimplant.org>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 933
Lines: 26

Patrick Mochel wrote:
> We talked about this in Ottawa a few months ago, and I think
> this is the right approach. Note though, that I think it
> needs to be more complete:
> 
> - There needs to be restore_state() to be symmetic.
> - There needs to be the proper failure recovery
>   If save_state() or suspend() fails, every device that has had their
>   state saved needs to be restored.
> - It needs to be called for all power management requests.

Agreed.

> - The PCI implementation should call pci_save_state() in it,
> instead of in ->suspend().

Also agree. And split pci_restore_state() from ->resume to
->restore_state. But all current drivers need to be rewritten.

Thanks,
-yi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/