Return-Path: <linux-kernel-owner+willy=40w.ods.org-S269101AbUIXUCM@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S269101AbUIXUCM (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 24 Sep 2004 16:02:12 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269102AbUIXUCM
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 24 Sep 2004 16:02:12 -0400
Received: from ppsw-5.csi.cam.ac.uk ([131.111.8.135]:1444 "EHLO
	ppsw-5.csi.cam.ac.uk") by vger.kernel.org with ESMTP
	id S269101AbUIXUCI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 24 Sep 2004 16:02:08 -0400
Date: Fri, 24 Sep 2004 21:02:05 +0100 (BST)
From: Anton Altaparmakov <aia21@cam.ac.uk>
To: Linus Torvalds <torvalds@osdl.org>
cc: viro@parcelfarce.linux.theplanet.co.uk, Andrew Morton <akpm@osdl.org>,
       linux-kernel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net
Subject: Re: [PATCH 8/10] Re: [2.6-BK-URL] NTFS: 2.1.19 sparse annotation,
 cleanups and a bugfix
In-Reply-To: <Pine.LNX.4.58.0409240926580.32117@ppc970.osdl.org>
Message-ID: <Pine.LNX.4.60.0409242059420.5443@hermes-1.csi.cam.ac.uk>
References: <Pine.LNX.4.60.0409241707370.19983@hermes-1.csi.cam.ac.uk>
 <Pine.LNX.4.60.0409241711400.19983@hermes-1.csi.cam.ac.uk>
 <Pine.LNX.4.60.0409241712320.19983@hermes-1.csi.cam.ac.uk>
 <Pine.LNX.4.60.0409241712490.19983@hermes-1.csi.cam.ac.uk>
 <Pine.LNX.4.60.0409241713070.19983@hermes-1.csi.cam.ac.uk>
 <Pine.LNX.4.60.0409241713220.19983@hermes-1.csi.cam.ac.uk>
 <Pine.LNX.4.60.0409241713380.19983@hermes-1.csi.cam.ac.uk>
 <Pine.LNX.4.60.0409241713540.19983@hermes-1.csi.cam.ac.uk>
 <Pine.LNX.4.60.0409241714190.19983@hermes-1.csi.cam.ac.uk>
 <Pine.LNX.4.58.0409240926580.32117@ppc970.osdl.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/
X-Cam-AntiVirus: No virus found
X-Cam-SpamDetails: Not scanned
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1684
Lines: 36

On Fri, 24 Sep 2004, Linus Torvalds wrote:
> On Fri, 24 Sep 2004, Anton Altaparmakov wrote:
> >    - Fix all the sparse bitwise warnings.  Had to change all the enums
> >      storing little endian values to #defines because we cannot set enums
> >      to be little endian so we had lots of bitwise warnings from sparse.
> 
> Btw, Al is fixing this. We'll make enum's properly typed, rather than just 
> plain integers. It's not traditional C behaviour, but it gives you better 
> type safety, and Al points out that other C compilers (the Plan 9 one, to 
> be specific) have done the same thing for similar reasons.
> 
> So we'll eventually be able to use enum's instead of #defines without
> losing any sparse information.
> 
> Of course, the only case where it matters is exactly cases like this, 
> where the difference between using an enum and a #define is basically a 
> matter of taste. But since I agree that enum's can look a lot nicer, it's 
> good to know that it's being worked on.

This is good news.  Once that is done I will be very happy to go back to 
using enums as I also agree that they can and in this case do look a 
lot nicer...

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/