Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269136AbUIXUnK (ORCPT ); Fri, 24 Sep 2004 16:43:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269135AbUIXUmr (ORCPT ); Fri, 24 Sep 2004 16:42:47 -0400 Received: from h-68-165-86-241.dllatx37.covad.net ([68.165.86.241]:62319 "EHLO sol.microgate.com") by vger.kernel.org with ESMTP id S269132AbUIXUk5 (ORCPT ); Fri, 24 Sep 2004 16:40:57 -0400 Subject: Re: 2.6.9-rc2-mm3 From: Paul Fulghum To: Russell King Cc: James Morris , Andrew Morton , linux-kernel , Alan Cox In-Reply-To: <20040924204345.C11325@flint.arm.linux.org.uk> References: <1096051977.1938.5.camel@deimos.microgate.com> <1096053328.1938.11.camel@deimos.microgate.com> <20040924204345.C11325@flint.arm.linux.org.uk> Content-Type: text/plain Message-Id: <1096058415.1981.25.camel@deimos.microgate.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Fri, 24 Sep 2004 15:40:15 -0500 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 29 On Fri, 2004-09-24 at 14:43, Russell King wrote: > a port supporting only 8 bit data transmission > must not report in termios that it is set to 7 bit data transmission. OK, the check should stay. Side note: the current check has an off by one bug: if (cbaud < 1 || cbaud + 15 > n_baud_table) termios->c_flag &= ~CBAUDEX; else cbaud += 15; where cbaud is an index into baud_table array and n_baud_table is the number of elements in baud_table. The conditional should be: if (cbaud < 1 || cbaud + 15 >= n_baud_table) -- Paul Fulghum paulkf@microgate.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/