Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269248AbUIYGfX (ORCPT ); Sat, 25 Sep 2004 02:35:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269252AbUIYGfX (ORCPT ); Sat, 25 Sep 2004 02:35:23 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:993 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S269248AbUIYGfT (ORCPT ); Sat, 25 Sep 2004 02:35:19 -0400 Date: Sat, 25 Sep 2004 07:35:19 +0100 From: viro@parcelfarce.linux.theplanet.co.uk To: Anton Altaparmakov Cc: Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net Subject: Re: [PATCH 6/10] Re: [2.6-BK-URL] NTFS: 2.1.19 sparse annotation, cleanups and a bugfix Message-ID: <20040925063519.GQ23987@parcelfarce.linux.theplanet.co.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 661 Lines: 12 On Fri, Sep 24, 2004 at 05:13:53PM +0100, Anton Altaparmakov wrote: > /* Get the starting vcn of the index_block holding the child node. */ > - vcn = sle64_to_cpup((u8*)ie + le16_to_cpu(ie->length) - 8); > + vcn = sle64_to_cpup((sle64*)((u8*)ie + le16_to_cpu(ie->length) - 8)); I don't like the look of that. Are there any alignment warranties for that pointer? The same goes for other users of that function... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/