Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269292AbUIYJ3b (ORCPT ); Sat, 25 Sep 2004 05:29:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269293AbUIYJ3a (ORCPT ); Sat, 25 Sep 2004 05:29:30 -0400 Received: from smtp6.wanadoo.fr ([193.252.22.25]:35994 "EHLO mwinf0609.wanadoo.fr") by vger.kernel.org with ESMTP id S269292AbUIYJ33 convert rfc822-to-8bit (ORCPT ); Sat, 25 Sep 2004 05:29:29 -0400 Subject: Re: 2.6.9-rc2-mm3 From: Xavier Bestel To: Russell King Cc: Paul Fulghum , William Lee Irwin III , James Morris , Andrew Morton , Linux Kernel Mailing List , Alan Cox In-Reply-To: <20040925101937.A29796@flint.arm.linux.org.uk> References: <20040925013135.GJ9106@holomorphy.com> <1096082711.7111.38.camel@at2.pipehead.org> <20040925101937.A29796@flint.arm.linux.org.uk> Content-Type: text/plain; charset=iso-8859-15 Message-Id: <1096104467.2918.16.camel@nomade> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Sat, 25 Sep 2004 11:27:49 +0200 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 25 Le sam 25/09/2004 ? 11:19, Russell King a ?crit : > I wonder if we should consider adding: > > WARN_ON(!spin_is_locked(&tty_termios_lock)); > > in there. > > However, the one annoying thing about "spin_is_locked" is that, on UP, > it defaults to "unlocked" which makes these kinds of checks too noisy. > Maybe we need a spin_is_locked() with a bias towards being locked for UP? Or something like: #define spin_is_safe(lock) ((!CONFIG_SMP) || spin_is_locked(lock)) (maybe as an inline) Xav - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/