Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269310AbUIYLPf (ORCPT ); Sat, 25 Sep 2004 07:15:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269311AbUIYLPf (ORCPT ); Sat, 25 Sep 2004 07:15:35 -0400 Received: from bhhdoa.org.au ([216.17.101.199]:23301 "EHLO bhhdoa.org.au") by vger.kernel.org with ESMTP id S269310AbUIYLPd (ORCPT ); Sat, 25 Sep 2004 07:15:33 -0400 Date: Sat, 25 Sep 2004 14:14:25 +0300 (EAT) From: Zwane Mwaikambo To: Kenji Kaneshige Cc: Linux Kernel , long Subject: Re: [ACPI] [PATCH] Updated patches for PCI IRQ resource deallocation support [2/3] In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 24 Kenji Kaneshige wrote: > - Changed acpi_pci_irq_disable() to leave 'dev->irq' as it > is. Clearing 'dev->irq' by some magic constant > (e.g. PCI_UNDEFINED_IRQ) is TBD. This may not be safe with CONFIG_PCI_MSI, you may want to verify against that if you already haven't. > +acpi_unregister_gsi (unsigned int irq) > +{ > +} > +EXPORT_SYMBOL(acpi_unregister_gsi); Why not just make these static inlines in header files? Since you're on this, how about making irq_desc and friends dynamic too? Thanks, Zwane - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/