Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269453AbUIZAdt (ORCPT ); Sat, 25 Sep 2004 20:33:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269464AbUIZAds (ORCPT ); Sat, 25 Sep 2004 20:33:48 -0400 Received: from mx1.redhat.com ([66.187.233.31]:41698 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S269451AbUIZAbZ (ORCPT ); Sat, 25 Sep 2004 20:31:25 -0400 Date: Sat, 25 Sep 2004 20:31:13 -0400 (EDT) From: Rik van Riel X-X-Sender: riel@chimarrao.boston.redhat.com To: Andrea Arcangeli cc: Benjamin Herrenschmidt , "Martin J. Bligh" , Andrew Morton , Linux Kernel list Subject: Re: ptep_establish/establish_pte needs set_pte_atomic and all set_pte must be written in asm In-Reply-To: <20040926002037.GP3309@dualathlon.random> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 830 Lines: 26 On Sun, 26 Sep 2004, Andrea Arcangeli wrote: > But even ppc64 is wrong as far as C is concerned, Looks fine to me. From include/asm-ppc64/pgtable.h static inline void set_pte(pte_t *ptep, pte_t pte) { if (pte_present(*ptep)) { pte_clear(ptep); flush_tlb_pending(); } *ptep = __pte(pte_val(pte)) & ~_PAGE_HPTEFLAGS; } -- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. Kernighan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/