Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269506AbUIZK7y (ORCPT ); Sun, 26 Sep 2004 06:59:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269508AbUIZK7y (ORCPT ); Sun, 26 Sep 2004 06:59:54 -0400 Received: from rproxy.gmail.com ([64.233.170.206]:18070 "EHLO mproxy.gmail.com") by vger.kernel.org with ESMTP id S269506AbUIZK7w (ORCPT ); Sun, 26 Sep 2004 06:59:52 -0400 Message-ID: <58cb370e04092603596138133a@mail.gmail.com> Date: Sun, 26 Sep 2004 12:59:48 +0200 From: Bartlomiej Zolnierkiewicz Reply-To: Bartlomiej Zolnierkiewicz To: Andries Brouwer Subject: Re: SiI3112 Serial ATA Maxtor 6Y120M0 incorrect geometry detected Cc: micah milano , linux-kernel@vger.kernel.org In-Reply-To: <20040926102937.GA27269@apps.cwi.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <70fda320409251214129bba57@mail.gmail.com> <70fda3204092514037c6dc039@mail.gmail.com> <58cb370e04092515157e9b72ef@mail.gmail.com> <20040926102937.GA27269@apps.cwi.nl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1365 Lines: 34 On Sun, 26 Sep 2004 12:29:37 +0200, Andries Brouwer wrote: > On Sun, Sep 26, 2004 at 12:15:33AM +0200, Bartlomiej Zolnierkiewicz wrote: > > > I'm tired of this issue and this is what I'm going to do: > > - remove CHS info from IDE printks and /proc/ide/ > > - add BLKGETSTART ioctl for getting partition's start sector > > (this is the only legitimate use of HDIO_GETGEO currently) > > - at least obsolete HDIO_GETGEO in IDE or even remove it (failing is > > better than returning unexpected results) > > - silence complainers :) > > > > Bartlomiej > > Yes. Consider returning 0 for C/H/S in HDIO_GETGEO. > > We need the BLKGETSTART ioctl for another reason: > the field start of a struct hd_geometry has 32 bits > and fails for partitions starting past the 2TB mark. > So, just like BLKGETSIZE64, this BLKGETSTART must > return a u64 and return an offset in bytes. Yes, I though so. Also u64 is 64-bit safe. > As we all know, geometry is meaningless for IDE. > But it is not for MFM/RLL and similar ancient stuff. > If support for old disks is not broken yet, try not to break it. OK. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/