Message-ID: <41583036.9010907@jaluna.com>
Date: Mon, 27 Sep 2004 17:22:30 +0200
From: Vladimir Grouzdev <vladimir.grouzdev@Jaluna.COM>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031030
MIME-Version: 1.0
To: linux-kernel@vger.kernel.org
CC: johnstul@us.ibm.com
Subject: 2.6.8.1: xtime value may become incorrect
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1520
Lines: 52


    The xtime value may become incorrect when the
    update_wall_time(ticks) function is called with "ticks" > 1.
    In such a case, the xtime variable is updated multiple times
    inside the loop but it is normalized only once outside of
    the loop.

    This bug was reported at:

    http://bugme.osdl.org/show_bug.cgi?id=3403

    Patch to fix the problem:

diff -Nrca linux-2.6.8.1/kernel/timer.c linux-2.6.8.1-patched/kernel/timer.c
*** linux-2.6.8.1/kernel/timer.c    2004-08-14 12:56:00.000000000 +0200
--- linux-2.6.8.1-patched/kernel/timer.c    2004-09-27 
16:24:48.000000000 +0200
***************
*** 776,788 ****
      do {
          ticks--;
          update_wall_time_one_tick();
      } while (ticks);
-
-     if (xtime.tv_nsec >= 1000000000) {
-         xtime.tv_nsec -= 1000000000;
-         xtime.tv_sec++;
-         second_overflow();
-     }
  }
 
  static inline void do_process_times(struct task_struct *p,
--- 776,787 ----
      do {
          ticks--;
          update_wall_time_one_tick();
+         if (xtime.tv_nsec >= 1000000000) {
+             xtime.tv_nsec -= 1000000000;
+             xtime.tv_sec++;
+             second_overflow();
+         }
      } while (ticks);
  }
 
  static inline void do_process_times(struct task_struct *p,


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/