Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266463AbUI0PfN (ORCPT ); Mon, 27 Sep 2004 11:35:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266505AbUI0PfN (ORCPT ); Mon, 27 Sep 2004 11:35:13 -0400 Received: from fw.osdl.org ([65.172.181.6]:52436 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S266463AbUI0PfB (ORCPT ); Mon, 27 Sep 2004 11:35:01 -0400 Date: Mon, 27 Sep 2004 08:34:50 -0700 (PDT) From: Linus Torvalds To: Alan Cox cc: Andrew Morton , Kernel Mailing List Subject: Re: PATCH: TTY ldisc and termios locking work In-Reply-To: <20040927143047.GA2921@devserv.devel.redhat.com> Message-ID: References: <20040927143047.GA2921@devserv.devel.redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 21 Alan, this seems to be corrupted. A quick read-through found this in generic_serial.c: + ld = tty_ldisc_ref(tty); + if (ld != NULL) { + ld->flush_buffer) + ld->flush_buffer(tty); + tty_ldisc_deref(ld); + } I can see the missing "if (" in my mind, but I'm wondering what else I might have missed. Ie can we have this patch be tested a bit more first? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/