Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266481AbUI0PmG (ORCPT ); Mon, 27 Sep 2004 11:42:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266491AbUI0PmG (ORCPT ); Mon, 27 Sep 2004 11:42:06 -0400 Received: from mx1.redhat.com ([66.187.233.31]:61583 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S266481AbUI0PmB (ORCPT ); Mon, 27 Sep 2004 11:42:01 -0400 Date: Mon, 27 Sep 2004 11:41:43 -0400 From: Alan Cox To: Linus Torvalds Cc: Alan Cox , Andrew Morton , Kernel Mailing List Subject: Re: PATCH: TTY ldisc and termios locking work Message-ID: <20040927154143.GA16399@devserv.devel.redhat.com> References: <20040927143047.GA2921@devserv.devel.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 22 On Mon, Sep 27, 2004 at 08:34:50AM -0700, Linus Torvalds wrote: > + ld = tty_ldisc_ref(tty); > + if (ld != NULL) { > + ld->flush_buffer) > + ld->flush_buffer(tty); > + tty_ldisc_deref(ld); > + } > > I can see the missing "if (" in my mind, but I'm wondering what else I > might have missed. Ie can we have this patch be tested a bit more first? Its been running for several days. generic_serial got missed because its BROKEN_ON_SMP for all users and so never got built. Fixed in my tree now. Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/