Date: Mon, 27 Sep 2004 12:48:36 -0700
From: Paul Jackson <pj@sgi.com>
To: Robert Love <rml@novell.com>
Cc: ttb@tentacle.dhs.org, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [RFC][PATCH] inotify 0.10.0
Message-Id: <20040927124836.2983ff9b.pj@sgi.com>
In-Reply-To: <1096305177.30503.65.camel@betsy.boston.ximian.com>
References: <1096250524.18505.2.camel@vertex>
	<1096305177.30503.65.camel@betsy.boston.ximian.com>
Organization: SGI
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 963
Lines: 27

> 	unsigned long		bitmask[MAX_INOTIFY_DEV_WATCHERS/BITS_PER_LONG];

This assumes that MAX_INOTIFY_DEV_WATCHERS is an integral multiple
of BITS_PER_LONG, otherwise, the last word will be missing.

Perhaps this would this better be written as:

	DECLARE_BITMAP(bitmask, MAX_INOTIFY_DEV_WATCHERS);

and the clearing of it in the original patch:

> +	memset(dev->bitmask, 0,
> +	  sizeof(unsigned long) * MAX_INOTIFY_DEV_WATCHERS / BITS_PER_LONG);

might better be written as:

	CLEAR_BITMAP(dev->bitmask, MAX_INOTIFY_DEV_WATCHERS);

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/